Skip to content

Support serialize UTF-8 String in HTTP Header Values #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 29, 2024
Merged

Support serialize UTF-8 String in HTTP Header Values #800

merged 7 commits into from
Jan 29, 2024

Conversation

bnusunny
Copy link
Contributor

Issue #, if available:

close #786

Description of changes:

Support serialize UTF-8 String in HTTP Header Values

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@bnusunny bnusunny requested a review from calavera January 28, 2024 13:48
calavera
calavera suggested changes Jan 28, 2024
View reviewed changes
Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some tests to prevent regressions?

@bnusunny bnusunny requested a review from calavera January 28, 2024 23:58
@bnusunny
Copy link
Contributor Author

Added a test to cover both serialize_headers and serialize_multi_value_headers.

@calavera calavera merged commit 2652b45 into main Jan 29, 2024
@calavera calavera deleted the support-utf-8-in-header-value branch January 29, 2024 01:16
@bnusunny bnusunny mentioned this pull request Feb 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calavera calavera calavera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bnusunny @calavera